Tutorial step 6 - Uplift to latest ink! and Openbrush #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maar-io
reviewed
Aug 1, 2023
| @@ -67,9 +62,44 @@ pub mod shiden34 { | |||
| }); | |||
| } | |||
|
|
|||
| impl payable_mint_pkg::impls::payable_mint::payable_mint::Internal for Shiden34 {} | |||
| impl payable_mint::Internal for Shiden34 {} | |||
|
|
|||
| impl payable_mint::PayableMintImpl for Shiden34 {} | |||
There was a problem hiding this comment.
yes, atm, otherwise the code won't compile
Maar-io
reviewed
Aug 1, 2023
| impl PayableMint for Shiden34 { | ||
| #[ink(message, payable)] | ||
| fn mint(&mut self, to: AccountId, mint_amount: u64) -> Result<(), PSP34Error> { | ||
| payable_mint::PayableMintImpl::mint(self, to, mint_amount) |
There was a problem hiding this comment.
I do not think this is a good way. You have 2 implementation of basically the same trait
It should be as simple as
impl payable_mint::PayableMint for Shiden34Contract {}
There was a problem hiding this comment.
This would be ideal. I will investigate how to do that with the latest Openbrush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.